[coreboot-gerrit] Change in coreboot[master]: drivers/intel/fsp2_0: Add support for FSP runs in long mode (x86_64)

[Tim Wawrzynczak (Code Review)]

Attention is currently required from: Subrata Banik, Wonkyu Kim, Mariusz Szafrański, Jonathan Zhang, Arthur Heymans, Andrey Petrov, Patrick Rudolph, Jason Glenesk, Anjaneya "Reddy" Chagam, Marshall Dawson, Johnny Lin, Christian Walter, Suresh Bellampalli, Vanessa Eusebio, Michal Motyl, Tim Chu, Felix Held.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59744 )

Change subject: drivers/intel/fsp2_0: Add support for FSP runs in long mode (x86_64)
......................................................................

Patch Set 7:

(2 comments)

File src/drivers/intel/fsp2_0/include/fsp/info_header.h:

https://review.coreboot.org/c/coreboot/+/59744/comment/50354ec7_59b60d97 
PS6, Line 41: uint64_t
> > it looks only address related parameters are changed to 64bit. […]

I agree with Arthur here, explicit is better with ABIs.

File src/vendorcode/intel/edk2/edk2-stable202005/IntelFsp2Pkg/Include/FspEas/FspApi.h:

https://review.coreboot.org/c/coreboot/+/59744/comment/a3c416fc_698a818a 
PS7, Line 192: Note: This ought to be VOID*, but that won't allow calling this binary on x86_64.
> not up to date anymore ;-)

🎉