Attention is currently required from: Subrata Banik, Wonkyu Kim, Mariusz Szafrański, Jonathan Zhang, Arthur Heymans, Andrey Petrov, Patrick Rudolph, Jason Glenesk, Anjaneya "Reddy" Chagam, Marshall Dawson, Johnny Lin, Christian Walter, Suresh Bellampalli, Vanessa Eusebio, Michal Motyl, Tim Chu, Felix Held.

View Change

2 comments:

• File src/drivers/intel/fsp2_0/include/fsp/info_header.h:

  • Patch Set #6, Line 41: uint64_t

    > it looks only address related parameters are changed to 64bit. […]

    I agree with Arthur here, explicit is better with ABIs.

• File src/vendorcode/intel/edk2/edk2-stable202005/IntelFsp2Pkg/Include/FspEas/FspApi.h:

  • Patch Set #7, Line 192: Note: This ought to be VOID*, but that won't allow calling this binary on x86_64.

    not up to date anymore ;-)

    🎉

To view, visit change 59744. To unsubscribe, or for help writing mail filters, visit settings.