Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41852 )
Change subject: sb/intel/bd82x6x/smihandler: Fix xHCI sleep handler
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41852/7/src/southbridge/intel/bd82x...
File src/southbridge/intel/bd82x6x/smihandler.c:
https://review.coreboot.org/c/coreboot/+/41852/7/src/southbridge/intel/bd82x...
PS7, Line 107: if (pch_silicon_type() == PCH_TYPE_PPT &&
: pch_silicon_revision() == PCH_STEP_A0) {
: break;
: }
This skips over the `pci_or_config16(PCH_XHCI_DEV, 0x74, 0x03);` at the end of this case, but doesn' […]
Just checked, the S3/S4 workaround is indeed specific to PPT A0, but the S5 workaround applies to all steppings.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41852
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idc658aa9fe11c8ee93290e3d3ef66e73476f3c57
Gerrit-Change-Number: 41852
Gerrit-PatchSet: 7
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 05 Jan 2021 22:11:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment