build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35230 )
Change subject: src/soc/intel/common/block/cse: Add print_me_fw_version() to cse lib. ......................................................................
Patch Set 1:
(82 comments)
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 786: struct version { code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 786: struct version { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 787: uint16_t minor; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 787: uint16_t minor; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 788: uint16_t major; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 788: uint16_t major; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 789: uint16_t build; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 789: uint16_t build; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 790: uint16_t hotfix; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 790: uint16_t hotfix; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 791: } __packed; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 791: } __packed; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 793: struct fw_ver_resp { code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 793: struct fw_ver_resp { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 794: struct mkhi_hdr hdr; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 794: struct mkhi_hdr hdr; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 795: struct version code; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 795: struct version code; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 796: struct version rec; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 796: struct version rec; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 797: struct version fitc; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 797: struct version fitc; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 798: } __packed; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 798: } __packed; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 800: union me_hfs hfsts1; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 800: union me_hfs hfsts1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 801: const struct mkhi_hdr fw_ver_msg = { code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 801: const struct mkhi_hdr fw_ver_msg = { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 802: .group_id = MKHI_GEN_GROUP_ID, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 802: .group_id = MKHI_GEN_GROUP_ID, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 803: .command = MKHI_GET_FW_VERSION, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 803: .command = MKHI_GET_FW_VERSION, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 804: }; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 804: }; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 805: struct fw_ver_resp resp; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 805: struct fw_ver_resp resp; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 806: size_t resp_size = sizeof(resp); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 806: size_t resp_size = sizeof(resp); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 808: /* Ignore if UART debugging is disabled */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 809: if (!CONFIG(CONSOLE_SERIAL)) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 809: if (!CONFIG(CONSOLE_SERIAL)) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 810: return; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 810: return; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 812: hfsts1.data = me_read_config32(PCI_ME_HFSTS1); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 812: hfsts1.data = me_read_config32(PCI_ME_HFSTS1); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 814: /* code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 815: * Prerequisites: code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 816: * 1) HFSTS1 Current Working State is Normal code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 817: * 2) HFSTS1 Current Operation Mode is Normal code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 818: * 3) It's after DRAM INIT DONE message (taken care of by calling it code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 819: * during ramstage code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 820: */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 821: if ((hfsts1.fields.working_state != ME_HFS_CWS_NORMAL) || code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 821: if ((hfsts1.fields.working_state != ME_HFS_CWS_NORMAL) || please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 822: (hfsts1.fields.operation_mode != ME_HFS_MODE_NORMAL)) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 822: (hfsts1.fields.operation_mode != ME_HFS_MODE_NORMAL)) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 823: goto fail; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 823: goto fail; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 825: heci_reset(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 825: heci_reset(); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 827: if (!heci_send(&fw_ver_msg, sizeof(fw_ver_msg), BIOS_HOST_ADDR, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 827: if (!heci_send(&fw_ver_msg, sizeof(fw_ver_msg), BIOS_HOST_ADDR, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 828: HECI_MKHI_ADDR)) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 828: HECI_MKHI_ADDR)) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 829: goto fail; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 829: goto fail; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 831: if (!heci_receive(&resp, &resp_size)) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 831: if (!heci_receive(&resp, &resp_size)) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 832: goto fail; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 832: goto fail; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 834: if (resp.hdr.result) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 834: if (resp.hdr.result) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 835: goto fail; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 835: goto fail; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 837: printk(BIOS_DEBUG, "ME: Version: %d.%d.%d.%d\n", resp.code.major, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 837: printk(BIOS_DEBUG, "ME: Version: %d.%d.%d.%d\n", resp.code.major, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 838: resp.code.minor, resp.code.hotfix, resp.code.build); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 838: resp.code.minor, resp.code.hotfix, resp.code.build); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 839: return; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 839: return; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 842: printk(BIOS_DEBUG, "ME: Version: Unavailable\n"); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 842: printk(BIOS_DEBUG, "ME: Version: Unavailable\n"); please, no spaces at the start of a line