Change in coreboot[master]: src/soc/intel/common/block/cse: Add print_me_fw_version() to cse lib.
Hello Rizwan Qureshi,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/35230
to review the following change.
Change subject: src/soc/intel/common/block/cse: Add print_me_fw_version() to cse lib. ......................................................................
src/soc/intel/common/block/cse: Add print_me_fw_version() to cse lib.
print_me_fw_version() - queries and logs ME's FW version.
Change-Id: I68a0338ed655c13a478e5dbcc58fc6a8844a5270 Signed-off-by: Rizwan Qureshi rizwan.qureshi@intel.com Signed-off-by: sridhar sridhar.siricilla@intel.com --- M src/soc/intel/common/block/cse/cse.c M src/soc/intel/common/block/include/intelblocks/cse.h 2 files changed, 73 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/35230/1
diff --git a/src/soc/intel/common/block/cse/cse.c b/src/soc/intel/common/block/cse/cse.c index d85209b..2845759 100644 --- a/src/soc/intel/common/block/cse/cse.c +++ b/src/soc/intel/common/block/cse/cse.c @@ -85,6 +85,9 @@ #define ME_HFS_CWS_NORMAL 5 #define ME_HFS_MODE_NORMAL 0
+#define MKHI_GEN_GROUP_ID 0xff +#define MKHI_GET_FW_VERSION 0x02 + static struct cse_device { uintptr_t sec_bar; } g_cse; @@ -122,7 +125,6 @@ uint8_t result; }__packed;
- /* * Initialize the device with provided temporary BAR. If BAR is 0 use a * default. This is intended for pre-mem usage only where BARs haven't been @@ -774,6 +776,72 @@ return -1; }
+/* + * From reading the documentation, this should work for both WHL and CML + * platforms. Also, calling this function from dump_me_status() does not + * work, as the ME does not respond and the command times out. + */ +void print_me_firmware_version(void *unused) +{ + struct version { + uint16_t minor; + uint16_t major; + uint16_t build; + uint16_t hotfix; + } __packed; + + struct fw_ver_resp { + struct mkhi_hdr hdr; + struct version code; + struct version rec; + struct version fitc; + } __packed; + + union me_hfs hfsts1; + const struct mkhi_hdr fw_ver_msg = { + .group_id = MKHI_GEN_GROUP_ID, + .command = MKHI_GET_FW_VERSION, + }; + struct fw_ver_resp resp; + size_t resp_size = sizeof(resp); + + /* Ignore if UART debugging is disabled */ + if (!CONFIG(CONSOLE_SERIAL)) + return; + + hfsts1.data = me_read_config32(PCI_ME_HFSTS1); + + /* + * Prerequisites: + * 1) HFSTS1 Current Working State is Normal + * 2) HFSTS1 Current Operation Mode is Normal + * 3) It's after DRAM INIT DONE message (taken care of by calling it + * during ramstage + */ + if ((hfsts1.fields.working_state != ME_HFS_CWS_NORMAL) || + (hfsts1.fields.operation_mode != ME_HFS_MODE_NORMAL)) + goto fail; + + heci_reset(); + + if (!heci_send(&fw_ver_msg, sizeof(fw_ver_msg), BIOS_HOST_ADDR, + HECI_MKHI_ADDR)) + goto fail; + + if (!heci_receive(&resp, &resp_size)) + goto fail; + + if (resp.hdr.result) + goto fail; + + printk(BIOS_DEBUG, "ME: Version: %d.%d.%d.%d\n", resp.code.major, + resp.code.minor, resp.code.hotfix, resp.code.build); + return; + +fail: + printk(BIOS_DEBUG, "ME: Version: Unavailable\n"); +} + #if ENV_RAMSTAGE
static void update_sec_bar(struct device *dev) diff --git a/src/soc/intel/common/block/include/intelblocks/cse.h b/src/soc/intel/common/block/include/intelblocks/cse.h index c0a5fef..f5c2b9e 100644 --- a/src/soc/intel/common/block/include/intelblocks/cse.h +++ b/src/soc/intel/common/block/include/intelblocks/cse.h @@ -89,6 +89,10 @@ */ int send_hmrfpo_get_status_msg(void);
+/* + * Queries and logs ME firmware version + */ +void print_me_firmware_version(void *unused);
#define BIOS_HOST_ADDR 0x00 #define HECI_MKHI_ADDR 0x07
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35230 )
Change subject: src/soc/intel/common/block/cse: Add print_me_fw_version() to cse lib. ......................................................................
Patch Set 1:
(82 comments)
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 786: struct version { code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 786: struct version { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 787: uint16_t minor; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 787: uint16_t minor; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 788: uint16_t major; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 788: uint16_t major; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 789: uint16_t build; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 789: uint16_t build; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 790: uint16_t hotfix; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 790: uint16_t hotfix; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 791: } __packed; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 791: } __packed; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 793: struct fw_ver_resp { code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 793: struct fw_ver_resp { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 794: struct mkhi_hdr hdr; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 794: struct mkhi_hdr hdr; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 795: struct version code; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 795: struct version code; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 796: struct version rec; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 796: struct version rec; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 797: struct version fitc; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 797: struct version fitc; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 798: } __packed; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 798: } __packed; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 800: union me_hfs hfsts1; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 800: union me_hfs hfsts1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 801: const struct mkhi_hdr fw_ver_msg = { code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 801: const struct mkhi_hdr fw_ver_msg = { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 802: .group_id = MKHI_GEN_GROUP_ID, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 802: .group_id = MKHI_GEN_GROUP_ID, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 803: .command = MKHI_GET_FW_VERSION, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 803: .command = MKHI_GET_FW_VERSION, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 804: }; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 804: }; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 805: struct fw_ver_resp resp; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 805: struct fw_ver_resp resp; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 806: size_t resp_size = sizeof(resp); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 806: size_t resp_size = sizeof(resp); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 808: /* Ignore if UART debugging is disabled */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 809: if (!CONFIG(CONSOLE_SERIAL)) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 809: if (!CONFIG(CONSOLE_SERIAL)) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 810: return; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 810: return; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 812: hfsts1.data = me_read_config32(PCI_ME_HFSTS1); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 812: hfsts1.data = me_read_config32(PCI_ME_HFSTS1); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 814: /* code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 815: * Prerequisites: code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 816: * 1) HFSTS1 Current Working State is Normal code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 817: * 2) HFSTS1 Current Operation Mode is Normal code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 818: * 3) It's after DRAM INIT DONE message (taken care of by calling it code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 819: * during ramstage code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 820: */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 821: if ((hfsts1.fields.working_state != ME_HFS_CWS_NORMAL) || code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 821: if ((hfsts1.fields.working_state != ME_HFS_CWS_NORMAL) || please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 822: (hfsts1.fields.operation_mode != ME_HFS_MODE_NORMAL)) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 822: (hfsts1.fields.operation_mode != ME_HFS_MODE_NORMAL)) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 823: goto fail; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 823: goto fail; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 825: heci_reset(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 825: heci_reset(); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 827: if (!heci_send(&fw_ver_msg, sizeof(fw_ver_msg), BIOS_HOST_ADDR, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 827: if (!heci_send(&fw_ver_msg, sizeof(fw_ver_msg), BIOS_HOST_ADDR, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 828: HECI_MKHI_ADDR)) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 828: HECI_MKHI_ADDR)) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 829: goto fail; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 829: goto fail; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 831: if (!heci_receive(&resp, &resp_size)) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 831: if (!heci_receive(&resp, &resp_size)) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 832: goto fail; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 832: goto fail; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 834: if (resp.hdr.result) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 834: if (resp.hdr.result) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 835: goto fail; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 835: goto fail; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 837: printk(BIOS_DEBUG, "ME: Version: %d.%d.%d.%d\n", resp.code.major, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 837: printk(BIOS_DEBUG, "ME: Version: %d.%d.%d.%d\n", resp.code.major, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 838: resp.code.minor, resp.code.hotfix, resp.code.build); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 838: resp.code.minor, resp.code.hotfix, resp.code.build); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 839: return; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 839: return; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 842: printk(BIOS_DEBUG, "ME: Version: Unavailable\n"); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 842: printk(BIOS_DEBUG, "ME: Version: Unavailable\n"); please, no spaces at the start of a line
Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35230 )
Change subject: src/soc/intel/common/block/cse: Add print_me_fw_version() to cse lib. ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35230/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35230/2//COMMIT_MSG@11 PS2, Line 11: * Fix all comments ion i not required
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35230 )
Change subject: src/soc/intel/common/block/cse: Add print_me_fw_version() to cse lib. ......................................................................
Patch Set 2:
(5 comments)
https://review.coreboot.org/c/coreboot/+/35230/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35230/2//COMMIT_MSG@2 PS2, Line 2: sridhar Please configure your full name.
$ git config -g user.name "…" $ git commit --amend --author="… <…@…>"
https://review.coreboot.org/c/coreboot/+/35230/2//COMMIT_MSG@7 PS2, Line 7: src/soc/intel/common/block/cse: Add print_me_fw_version() to cse lib. Please remove the dot at the end.
https://review.coreboot.org/c/coreboot/+/35230/2//COMMIT_MSG@12 PS2, Line 12: Tested how?
https://review.coreboot.org/c/coreboot/+/35230/2//COMMIT_MSG@15 PS2, Line 15: sridhar Full name please.
https://review.coreboot.org/c/coreboot/+/35230/2/src/soc/intel/common/block/... File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/35230/2/src/soc/intel/common/block/... PS2, Line 89: #define MKHI_GET_FW_VERSION 0x02 Alignment seems off.
Hello Patrick Rudolph, Subrata Banik, Aamir Bohra, Rizwan Qureshi, V Sowmya, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35230
to look at the new patch set (#3).
Change subject: src/soc/intel/common/block/cse: Add print_me_fw_version() to cse lib ......................................................................
src/soc/intel/common/block/cse: Add print_me_fw_version() to cse lib
print_me_fw_version() - queries and logs ME's FW version.
Change-Id: I68a0338ed655c13a478e5dbcc58fc6a8844a5270 Signed-off-by: Rizwan Qureshi rizwan.qureshi@intel.com Signed-off-by: Sridhar Siricilla sridhar.siricilla@intel.com --- M src/soc/intel/common/block/cse/cse.c M src/soc/intel/common/block/include/intelblocks/cse.h 2 files changed, 73 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/35230/3
Hello Patrick Rudolph, Subrata Banik, Aamir Bohra, Rizwan Qureshi, V Sowmya, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35230
to look at the new patch set (#8).
Change subject: src/soc/intel/common/block/cse: Add print_me_fw_version() to cse lib ......................................................................
src/soc/intel/common/block/cse: Add print_me_fw_version() to cse lib
print_me_fw_version() - queries and logs ME's FW version.
Change-Id: I68a0338ed655c13a478e5dbcc58fc6a8844a5270 Signed-off-by: Rizwan Qureshi rizwan.qureshi@intel.com Signed-off-by: Sridhar Siricilla sridhar.siricilla@intel.com --- M src/soc/intel/common/block/cse/cse.c M src/soc/intel/common/block/include/intelblocks/cse.h 2 files changed, 73 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/35230/8
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35230 )
Change subject: src/soc/intel/common/block/cse: Add print_me_fw_version() to cse lib ......................................................................
Patch Set 8:
(5 comments)
https://review.coreboot.org/c/coreboot/+/35230/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35230/2//COMMIT_MSG@2 PS2, Line 2: sridhar
Please configure your full name. […]
Done
https://review.coreboot.org/c/coreboot/+/35230/2//COMMIT_MSG@7 PS2, Line 7: src/soc/intel/common/block/cse: Add print_me_fw_version() to cse lib.
Please remove the dot at the end.
Done
https://review.coreboot.org/c/coreboot/+/35230/2//COMMIT_MSG@11 PS2, Line 11: * Fix all comments ion i
not required
Done
https://review.coreboot.org/c/coreboot/+/35230/2//COMMIT_MSG@15 PS2, Line 15: sridhar
Full name please.
Done
https://review.coreboot.org/c/coreboot/+/35230/2/src/soc/intel/common/block/... File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/35230/2/src/soc/intel/common/block/... PS2, Line 89: #define MKHI_GET_FW_VERSION 0x02
Alignment seems off.
Done
Hello Patrick Rudolph, Subrata Banik, Aamir Bohra, Rizwan Qureshi, V Sowmya, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35230
to look at the new patch set (#9).
Change subject: src/soc/intel/common/block/cse: Add print_me_fw_version() to cse lib ......................................................................
src/soc/intel/common/block/cse: Add print_me_fw_version() to cse lib
print_me_fw_version() - queries and logs ME's FW version.
TEST=Verified on CML RVP & hatch board
Change-Id: I68a0338ed655c13a478e5dbcc58fc6a8844a5270 Signed-off-by: Rizwan Qureshi rizwan.qureshi@intel.com Signed-off-by: Sridhar Siricilla sridhar.siricilla@intel.com --- M src/soc/intel/common/block/cse/cse.c M src/soc/intel/common/block/include/intelblocks/cse.h 2 files changed, 73 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/35230/9
Hello Patrick Rudolph, Subrata Banik, Aamir Bohra, Rizwan Qureshi, V Sowmya, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35230
to look at the new patch set (#10).
Change subject: src/soc/intel/common/block/cse: Add print_me_fw_version() to cse lib ......................................................................
src/soc/intel/common/block/cse: Add print_me_fw_version() to cse lib
print_me_fw_version() - queries and logs ME's FW version.
TEST=Verified printing ME Version on CML RVP & hatch board
Change-Id: I68a0338ed655c13a478e5dbcc58fc6a8844a5270 Signed-off-by: Rizwan Qureshi rizwan.qureshi@intel.com Signed-off-by: Sridhar Siricilla sridhar.siricilla@intel.com --- M src/soc/intel/common/block/cse/cse.c M src/soc/intel/common/block/include/intelblocks/cse.h 2 files changed, 73 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/35230/10
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35230 )
Change subject: src/soc/intel/common/block/cse: Add print_me_fw_version() to cse lib ......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35230/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35230/2//COMMIT_MSG@11 PS2, Line 11: * Fix all comments ion i
Done
Done
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35230 )
Change subject: src/soc/intel/common/block/cse: Add print_me_fw_version() to cse lib ......................................................................
Patch Set 11:
(82 comments)
https://review.coreboot.org/c/coreboot/+/35230/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35230/2//COMMIT_MSG@12 PS2, Line 12:
Tested how?
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 786: struct version {
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 786: struct version {
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 787: uint16_t minor;
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 787: uint16_t minor;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 788: uint16_t major;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 788: uint16_t major;
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 789: uint16_t build;
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 789: uint16_t build;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 790: uint16_t hotfix;
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 790: uint16_t hotfix;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 791: } __packed;
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 791: } __packed;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 793: struct fw_ver_resp {
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 793: struct fw_ver_resp {
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 794: struct mkhi_hdr hdr;
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 794: struct mkhi_hdr hdr;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 795: struct version code;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 795: struct version code;
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 796: struct version rec;
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 796: struct version rec;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 797: struct version fitc;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 797: struct version fitc;
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 798: } __packed;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 798: } __packed;
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 800: union me_hfs hfsts1;
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 800: union me_hfs hfsts1;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 801: const struct mkhi_hdr fw_ver_msg = {
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 801: const struct mkhi_hdr fw_ver_msg = {
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 802: .group_id = MKHI_GEN_GROUP_ID,
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 802: .group_id = MKHI_GEN_GROUP_ID,
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 803: .command = MKHI_GET_FW_VERSION,
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 803: .command = MKHI_GET_FW_VERSION,
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 804: };
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 804: };
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 805: struct fw_ver_resp resp;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 805: struct fw_ver_resp resp;
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 806: size_t resp_size = sizeof(resp);
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 806: size_t resp_size = sizeof(resp);
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 808: /* Ignore if UART debugging is disabled */
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 809: if (!CONFIG(CONSOLE_SERIAL))
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 809: if (!CONFIG(CONSOLE_SERIAL))
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 810: return;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 810: return;
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 812: hfsts1.data = me_read_config32(PCI_ME_HFSTS1);
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 812: hfsts1.data = me_read_config32(PCI_ME_HFSTS1);
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 814: /*
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 815: * Prerequisites:
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 816: * 1) HFSTS1 Current Working State is Normal
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 817: * 2) HFSTS1 Current Operation Mode is Normal
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 818: * 3) It's after DRAM INIT DONE message (taken care of by calling it
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 819: * during ramstage
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 820: */
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 821: if ((hfsts1.fields.working_state != ME_HFS_CWS_NORMAL) ||
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 821: if ((hfsts1.fields.working_state != ME_HFS_CWS_NORMAL) ||
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 822: (hfsts1.fields.operation_mode != ME_HFS_MODE_NORMAL))
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 822: (hfsts1.fields.operation_mode != ME_HFS_MODE_NORMAL))
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 823: goto fail;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 823: goto fail;
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 825: heci_reset();
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 825: heci_reset();
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 827: if (!heci_send(&fw_ver_msg, sizeof(fw_ver_msg), BIOS_HOST_ADDR,
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 827: if (!heci_send(&fw_ver_msg, sizeof(fw_ver_msg), BIOS_HOST_ADDR,
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 828: HECI_MKHI_ADDR))
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 828: HECI_MKHI_ADDR))
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 829: goto fail;
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 829: goto fail;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 831: if (!heci_receive(&resp, &resp_size))
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 831: if (!heci_receive(&resp, &resp_size))
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 832: goto fail;
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 832: goto fail;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 834: if (resp.hdr.result)
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 834: if (resp.hdr.result)
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 835: goto fail;
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 835: goto fail;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 837: printk(BIOS_DEBUG, "ME: Version: %d.%d.%d.%d\n", resp.code.major,
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 837: printk(BIOS_DEBUG, "ME: Version: %d.%d.%d.%d\n", resp.code.major,
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 838: resp.code.minor, resp.code.hotfix, resp.code.build);
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 839: return;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 839: return;
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 842: printk(BIOS_DEBUG, "ME: Version: Unavailable\n");
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35230/1/src/soc/intel/common/block/... PS1, Line 842: printk(BIOS_DEBUG, "ME: Version: Unavailable\n");
code indent should use tabs where possible
Done
Hello Patrick Rudolph, Subrata Banik, Aamir Bohra, Rizwan Qureshi, V Sowmya, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35230
to look at the new patch set (#13).
Change subject: src/soc/intel/common/block/cse: Add print_me_fw_version() to cse lib ......................................................................
src/soc/intel/common/block/cse: Add print_me_fw_version() to cse lib
print_me_fw_version() - queries and logs ME's FW version.
TEST=Verified printing ME Version on CML RVP & hatch board
Change-Id: I68a0338ed655c13a478e5dbcc58fc6a8844a5270 Signed-off-by: Rizwan Qureshi rizwan.qureshi@intel.com Signed-off-by: Sridhar Siricilla sridhar.siricilla@intel.com --- M src/soc/intel/common/block/cse/cse.c M src/soc/intel/common/block/include/intelblocks/cse.h 2 files changed, 73 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/35230/13
Sridhar Siricilla has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/35230 )
Change subject: src/soc/intel/common/block/cse: Add print_me_fw_version() to cse lib ......................................................................
Abandoned
later use....
-
build bot (Jenkins) (Code Review) -
Paul Menzel (Code Review)
-
Rizwan Qureshi (Code Review)
-
Sridhar Siricilla (Code Review)