Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45459 )
Change subject: lib/spd: respect spd memory part name override if present ......................................................................
Patch Set 16:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45459/16/src/lib/spd_bin.c File src/lib/spd_bin.c:
https://review.coreboot.org/c/coreboot/+/45459/16/src/lib/spd_bin.c@202 PS16, Line 202: spd_get_name(spd, spd_name, ARRAY_SIZE(spd_name), type); : : printk(BIOS_INFO, "SPD: module part number is %s\n", spd_name);
Sorry, I am a little late to the party here. […]
Great suggestion, Furquan, I will upload a CL implementing this change later today.
re: Additionally, we can provide the strong implementation of `mainboard_get_dram_part_num()` in src/vendorcode/google/chromeos/ so that it can be used by mainboards without having to duplicate that code by selecting a Kconfig.
Does this mean (this change will mean) that all mainboards going forward on chromeos will define their memory part number in the CBI? Is that a mandate for all chromebooks?