View Change
1 comment:
File src/lib/spd_bin.c:
Patch Set #16, Line 202:
spd_get_name(spd, spd_name, ARRAY_SIZE(spd_name), type);
printk(BIOS_INFO, "SPD: module part number is %s\n", spd_name);
Sorry, I am a little late to the party here. […]
Great suggestion, Furquan, I will upload a CL implementing this change later today.
re: Additionally, we can provide the strong implementation of `mainboard_get_dram_part_num()` in src/vendorcode/google/chromeos/ so that it can be used by mainboards without having to duplicate that code by selecting a Kconfig.
Does this mean (this change will mean) that all mainboards going forward on chromeos will define their memory part number in the CBI? Is that a mandate for all chromebooks?
To view, visit change 45459. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I91971e07c450492dbb0588abd1c3c692ee0d3bb0
Gerrit-Change-Number: 45459
Gerrit-PatchSet: 16
Gerrit-Owner: Nick Vaccaro <nvaccaro@google.com>
Gerrit-Reviewer: Caveh Jalali <caveh@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Aaron Durbin <adurbin@chromium.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-CC: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Comment-Date: Mon, 21 Sep 2020 20:22:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan@google.com>
Gerrit-MessageType: comment