Attention is currently required from: Bao Zheng, Raul Rangel, Martin Roth.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49015 )
Change subject: amdfwtool: Use *number in config file as NVRAM entry
......................................................................
Patch Set 30:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49015/comment/779aabb2_d218defa
PS30, Line 7: Use *number in config file
Why is this needed? What's the purpose?
the purpose is to be able to add empty regions to amdfw without having to have empty blobs with the right size in the blobs repo. so in the fw.cfg file those can be used instead of file names pointing to files in amd_blobs. i think the psp wants to have some empty region for something, but i might misremember; didn't get around to have a close look
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49015
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I98c94b4087f8a174f7d5753a30695a10f1b796ae
Gerrit-Change-Number: 49015
Gerrit-PatchSet: 30
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Comment-Date: Thu, 11 Feb 2021 19:41:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment