Attention is currently required from: Elyes Haouas, Nicholas Sudsgaard, Paul Menzel.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80332?usp=email )
Change subject: device/azalia: Clean up codec initialization code ......................................................................
Patch Set 6: Code-Review+1
(3 comments)
File src/device/azalia_device.c:
https://review.coreboot.org/c/coreboot/+/80332/comment/35bba7c9_1ed7dc98 : PS6, Line 259: load_verb Maybe rather `load_verb_table`. I got a bit confused because we have azalia_write_verb() and load_verb(), one refers to a single verb command and the other to the table.
Though, IMO, the separation looks a bit overdone. Personally, I would keep the error handling inline in azalia_codec_init(). But I leave that to you.
https://review.coreboot.org/c/coreboot/+/80332/comment/684fd323_0deadd57 : PS6, Line 272: size It's more of a `count'. But maybe that's something to take care of later.
File src/include/device/azalia_device.h:
https://review.coreboot.org/c/coreboot/+/80332/comment/90af9545_677722fd : PS5, Line 13:
Hmmm, I think I see the intention here, do you think it would be better keeping this? I would be lea […]
It's common to indent the bit definitions.