Attention is currently required from: Elyes Haouas, Nicholas Sudsgaard, Paul Menzel.
Patch set 6:Code-Review +1
3 comments:
File src/device/azalia_device.c:
Patch Set #6, Line 259: load_verb
Maybe rather `load_verb_table`. I got a bit confused because we have
azalia_write_verb() and load_verb(), one refers to a single verb command
and the other to the table.
Though, IMO, the separation looks a bit overdone. Personally, I would keep
the error handling inline in azalia_codec_init(). But I leave that to you.
It's more of a `count'. But maybe that's something to take care of later.
File src/include/device/azalia_device.h:
Hmmm, I think I see the intention here, do you think it would be better keeping this? I would be lea […]
It's common to indent the bit definitions.
To view, visit change 80332. To unsubscribe, or for help writing mail filters, visit settings.