[coreboot-gerrit] Change in ...coreboot[master]: mediatek/mt8183: Support gpio eh and rsel setting for I2C

[wang qii (Code Review)]

wang qii has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30974 )

Change subject: mediatek/mt8183: Support gpio eh and rsel setting for I2C
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/30974/2/src/soc/mediatek/mt8183/gpio.c 
File src/soc/mediatek/mt8183/gpio.c:

https://review.coreboot.org/#/c/30974/2/src/soc/mediatek/mt8183/gpio.c@107 
PS2, Line 107: 	void *reg = GPIO_TO_IOCFG_BASE(gpio.base) + EH_RSEL_OFFSET;
> This APIs is provided to facilitate adjustment of different boards and different speed specification […]

What is your brilliant opinion? Which way is better?