Attention is currently required from: Nico Huber, Eugene Myers, Paul Menzel, Angel Pons, Michael Niewöhner.
Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G
......................................................................
Patch Set 190:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/35523/comment/2ef1029b_105eb914
PS186, Line 19: - TianoCore
Which version?
Done. I don't particularly mind providing it, but is version information actually helpful to users or contributors?
Patchset:
PS186:
It makes sense to split up new platform support (e.g. […]
Right, but the commit is fairly large. I thought that perhaps splitting it would make it easier to review (and therefore, merge sooner?). However, I'm fine with it all at once.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35523
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6340116abfeb2fbd280d143b74d323e4da3566f6
Gerrit-Change-Number: 35523
Gerrit-PatchSet: 190
Gerrit-Owner: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eugene Myers
cedarhouse1@comcast.net
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Eugene Myers
cedarhouse1@comcast.net
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Sun, 07 Nov 2021 00:13:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Comment-In-Reply-To: Benjamin Doron
benjamin.doron00@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment