Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G
......................................................................
Patch Set 54:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35523/45//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35523/45//COMMIT_MSG@28
PS45, Line 28: - Remaining RAM slots (need other SPD addresses)
I know. I added a second RAM stick to this laptop once. […]
(the board in the image isn't your board, but if you only saw two slots then it's all good)
https://review.coreboot.org/c/coreboot/+/35523/54/src/mainboard/acer/aspire_...
File src/mainboard/acer/aspire_vn7_572g/ramstage.c:
https://review.coreboot.org/c/coreboot/+/35523/54/src/mainboard/acer/aspire_...
PS54, Line 33: gpio_get(DGPU_PRESENT)
Schematics: "H: UMA, L: OPTIMUS" […]
Oh, you managed to get the schematics?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35523
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6340116abfeb2fbd280d143b74d323e4da3566f6
Gerrit-Change-Number: 35523
Gerrit-PatchSet: 54
Gerrit-Owner: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 13 Jan 2020 09:06:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-MessageType: comment