Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42808 )
Change subject: src/amd/common: Exclude biosram from psp_verstage ......................................................................
Patch Set 5:
Patch Set 2:
My previous requests for excluding some of these files from psp-verstage was due to my misunderstanding of having no <arch/io.h> for ENV_ARM. In my opinion, the use of verstage_x86 should only be applied to files with dependencies on <arch/x86/xx> or <cpu/x86/xx>.
As I see it, PSP kernel will provide some routing of x86 IO space to MMIO space, and you will provide <arch/io.h> somewhere. In my opinion it is desireable to be able to build CMOS/NVRAM and POST80 ioport into verstage, even if you do not currently use those. I don't immediately see where the build would currently fail and applying verstage_x86 seems unnecessary with garbage collection.
Updated to only remove biosram.c