Patch Set 2:

My previous requests for excluding some of these files from psp-verstage was due to my misunderstanding of having no <arch/io.h> for ENV_ARM. In my opinion, the use of verstage_x86 should only be applied to files with dependencies on <arch/x86/xx> or <cpu/x86/xx>.

As I see it, PSP kernel will provide some routing of x86 IO space to MMIO space, and you will provide <arch/io.h> somewhere. In my opinion it is desireable to be able to build CMOS/NVRAM and POST80 ioport into verstage, even if you do not currently use those. I don't immediately see where the build would currently fail and applying verstage_x86 seems unnecessary with garbage collection.

Updated to only remove biosram.c

View Change

To view, visit change 42808. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I63942ad896d205c327d65bb8083da817b972962b
Gerrit-Change-Number: 42808
Gerrit-PatchSet: 5
Gerrit-Owner: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Wed, 08 Jul 2020 20:49:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment