Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33621 )
Change subject: soc/amd/stoneyridge: Add merlinfalcon configuration ......................................................................
Patch Set 2:
(5 comments)
https://review.coreboot.org/#/c/33621/2/src/soc/amd/stoneyridge/Kconfig File src/soc/amd/stoneyridge/Kconfig:
https://review.coreboot.org/#/c/33621/2/src/soc/amd/stoneyridge/Kconfig@26 PS2, Line 26: _FP4
You could drop the FP4 designation just like in 00660F01. […]
Good to know, will drop... though it might have a cascade effect in some other patches.
https://review.coreboot.org/#/c/33621/2/src/soc/amd/stoneyridge/Kconfig@83 PS2, Line 83: config CPU_SPECIFIC_OPTIONS
Is there any difference besides SOC_AMD_PSP_SELECTABLE_SMU_FW? For that, duplicate the item from co […]
That's the only difference, so I'll try your suggestion.
https://review.coreboot.org/#/c/33621/2/src/soc/amd/stoneyridge/Kconfig@201 PS2, Line 201: 00660F01/VBIOS.bin
I would go ahead and duplicate VBIOS.bin into the merlinfalcon directory. […]
I already did that when adding the blobs, I just missed it here. Will fix.
https://review.coreboot.org/#/c/33621/2/src/soc/amd/stoneyridge/Makefile.inc File src/soc/amd/stoneyridge/Makefile.inc:
https://review.coreboot.org/#/c/33621/2/src/soc/amd/stoneyridge/Makefile.inc... PS2, Line 146: MF
You changed the filenames from their originals? I thought everything was CZ/BR/ST.
Yes, I did, though I could have used CZ. Mostly because of the 2 fake _FN files, I wanted them on a separate folder and trully identify them as merlinfalcon only. However, with a different change you sugested on a different patch, this might not be the case anymore... if it all goes as expected, I'll make these files back to CZ.
https://review.coreboot.org/#/c/33621/2/src/soc/amd/stoneyridge/Makefile.inc... PS2, Line 239: ifeq ($(CONFIG_SOC_AMD_MERLINFALCON_FP4),y)
Is this all so that you can remove --combo-capable? I didn't notice any other differences. […]
Could you explain better? Not sure what you are saying here.