Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44748 )
Change subject: mb/volteer: Remove DQ/DQS mappings for LPDDR4 ......................................................................
Patch Set 4:
(5 comments)
https://review.coreboot.org/c/coreboot/+/44748/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44748/4//COMMIT_MSG@9 PS4, Line 9: MRC v0.7.0 What FSP version does this correspond to? We need to ensure that proper Cq-Depends are set up on the FSP changes.
https://review.coreboot.org/c/coreboot/+/44748/4/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/memory.c:
https://review.coreboot.org/c/coreboot/+/44748/4/src/mainboard/google/voltee... PS4, Line 9: dqs_map dqs_map is not really dropped here and in other variants.
https://review.coreboot.org/c/coreboot/+/44748/4/src/soc/intel/tigerlake/inc... File src/soc/intel/tigerlake/include/soc/meminit.h:
https://review.coreboot.org/c/coreboot/+/44748/4/src/soc/intel/tigerlake/inc... PS4, Line 89: dqs_map This needs to be dropped as well as per commit message.
https://review.coreboot.org/c/coreboot/+/44748/4/src/soc/intel/tigerlake/inc... PS4, Line 100: This part of the change is wrong. You are dropping dq/dqs mappings for DDR4 here.
https://review.coreboot.org/c/coreboot/+/44748/4/src/soc/intel/tigerlake/mem... File src/soc/intel/tigerlake/meminit.c:
https://review.coreboot.org/c/coreboot/+/44748/4/src/soc/intel/tigerlake/mem... PS4, Line 392: This is not correct. You are dropping the mappings for DDR4.