View Change

5 comments:

• Commit Message:

  • Patch Set #4, Line 9: MRC v0.7.0

    What FSP version does this correspond to? We need to ensure that proper Cq-Depends are set up on the FSP changes.

• File src/mainboard/google/volteer/variants/baseboard/memory.c:

  • Patch Set #4, Line 9: dqs_map

    dqs_map is not really dropped here and in other variants.

• File src/soc/intel/tigerlake/include/soc/meminit.h:

  • Patch Set #4, Line 89: dqs_map

    This needs to be dropped as well as per commit message.

  • Patch Set #4, Line 100:

    This part of the change is wrong. You are dropping dq/dqs mappings for DDR4 here.

• File src/soc/intel/tigerlake/meminit.c:

  • Patch Set #4, Line 392:

    This is not correct. You are dropping the mappings for DDR4.

To view, visit change 44748. To unsubscribe, or for help writing mail filters, visit settings.