Attention is currently required from: Shelley Chen, Ravi kumar, Martin Roth, Paul Menzel, Julius Werner, mturney mturney. Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45205 )
Change subject: sc7280: Provide initial SoC support ......................................................................
Patch Set 33:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/45205/comment/617effab_8e8cecdd PS15, Line 8:
Agreed. Please write a brief description and also please include: […]
Ack
File src/soc/qualcomm/sc7280/memlayout.ld:
https://review.coreboot.org/c/coreboot/+/45205/comment/fff877f2_eebcbf92 PS24, Line 8: #define SSRAM_END(addr) SYMBOL(essram, addr)
i will update
addressed
https://review.coreboot.org/c/coreboot/+/45205/comment/c3fc56e8_74961cff PS24, Line 42: FMAP_CACHE(0x1485B400, 2K)
sure i will update
Ack
File src/soc/qualcomm/sc7280/qclib.c:
https://review.coreboot.org/c/coreboot/+/45205/comment/94839421_76a5acbc PS6, Line 9: int qclib_soc_blob_load(void)
Sure julius, […]
Ack
File src/soc/qualcomm/sc7280/qclib.c:
https://review.coreboot.org/c/coreboot/+/45205/comment/d623adea_30a2ee61 PS24, Line 12: ssize_t ssize;
I don't see this change in the other CL yet. […]
Ack
https://review.coreboot.org/c/coreboot/+/45205/comment/1c408e01_e12efc6e PS24, Line 15: size = cbfs_boot_load_file(CONFIG_CBFS_PREFIX "/pmiccfg",
Same comment as above. I think that these changes should be merged into this patch.
addressed