Attention is currently required from: Shelley Chen, Ravi kumar, Martin Roth, Paul Menzel, Julius Werner, mturney mturney.
View Change
6 comments:
Commit Message:
File src/soc/qualcomm/sc7280/memlayout.ld:
File src/soc/qualcomm/sc7280/qclib.c:
File src/soc/qualcomm/sc7280/qclib.c:
Patch Set #24, Line 12: ssize_t ssize;
I don't see this change in the other CL yet. […]
Ack
Patch Set #24, Line 15: size = cbfs_boot_load_file(CONFIG_CBFS_PREFIX "/pmiccfg",
Same comment as above. I think that these changes should be merged into this patch.
addressed
To view, visit change 45205. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1fc841b3113f2bf79b8376cd1ccdb671c53c2084
Gerrit-Change-Number: 45205
Gerrit-PatchSet: 33
Gerrit-Owner: Ravi kumar <rbokka@codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: mturney mturney <mturney@codeaurora.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka@qualcomm.corp-partner.google.com>
Gerrit-CC: Shelley Chen <shchen@google.com>
Gerrit-Attention: Shelley Chen <shchen@google.com>
Gerrit-Attention: Ravi kumar <rbokka@codeaurora.org>
Gerrit-Attention: Martin Roth <martinroth@google.com>
Gerrit-Attention: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Attention: Julius Werner <jwerner@chromium.org>
Gerrit-Attention: mturney mturney <mturney@codeaurora.org>
Gerrit-Comment-Date: Tue, 23 Mar 2021 18:35:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen <shchen@google.com>
Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net>
Comment-In-Reply-To: Ravi Kumar Bokka <c_rbokka@qualcomm.corp-partner.google.com>
Comment-In-Reply-To: Julius Werner <jwerner@chromium.org>
Gerrit-MessageType: comment