wang qii has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30974 )
Change subject: mediatek/mt8183: Support gpio eh and rsel setting for I2C
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/30974/1/src/soc/mediatek/mt8183/gpio.c
File src/soc/mediatek/mt8183/gpio.c:
https://review.coreboot.org/#/c/30974/1/src/soc/mediatek/mt8183/gpio.c@98
PS1, Line 98: MTK_I2C_PIN_SPEC(PAD_SDA4_ID, 17, 12),
What I2C device are you driving at more than 1MHz in firmware? Note that if this is only necessary f […]
By default settings must be reset, otherwise the low level of i2c is too high.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30974
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I518ca07645fe55aa55e94e4f98178baa0b74a882
Gerrit-Change-Number: 30974
Gerrit-PatchSet: 2
Gerrit-Owner: wang qii
Qii.Wang@mediatek.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: wang qii
Qii.Wang@mediatek.com
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-Comment-Date: Wed, 23 Jan 2019 09:23:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: wang qii
Qii.Wang@mediatek.com
Gerrit-MessageType: comment