Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33287 )
Change subject: payloads/libpayload: Update a Makefile and a wrapper of a compiler in libpayload in order to build sample payload for QEMU/ARM. ......................................................................
Patch Set 6:
(2 comments)
+1 to everything Raul said.
https://review.coreboot.org/#/c/33287/6/payloads/libpayload/README File payloads/libpayload/README:
https://review.coreboot.org/#/c/33287/6/payloads/libpayload/README@28 PS6, Line 28: you might have to install the 32bit libgcc version, otherwise This doesn't really make sense, the issue this is talking about is x86 specific. So I think you should rather change this to something like
On x86 systems, libpayload will always be 32-bit even if your host OS runs in 64-bit, so you might have to install the 32-bit libgcc version.
The issue is arguably moot these days because people should be using the coreboot toolchain anyway, which will build all the right libraries.
https://review.coreboot.org/#/c/33287/6/payloads/libpayload/sample/Makefile File payloads/libpayload/sample/Makefile:
https://review.coreboot.org/#/c/33287/6/payloads/libpayload/sample/Makefile@... PS6, Line 35:
Why are you removing the three archs?
POWERPC support has been removed a long time ago so I believe this is correct.