Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33287 ) Change subject: payloads/libpayload: Update a Makefile and a wrapper of a compiler in libpayload in order to build sample payload for QEMU/ARM. ...................................................................... Patch Set 6: (2 comments) +1 to everything Raul said. https://review.coreboot.org/#/c/33287/6/payloads/libpayload/README File payloads/libpayload/README: https://review.coreboot.org/#/c/33287/6/payloads/libpayload/README@28 PS6, Line 28: you might have to install the 32bit libgcc version, otherwise This doesn't really make sense, the issue this is talking about is x86 specific. So I think you should rather change this to something like On x86 systems, libpayload will always be 32-bit even if your host OS runs in 64-bit, so you might have to install the 32-bit libgcc version. The issue is arguably moot these days because people should be using the coreboot toolchain anyway, which will build all the right libraries. https://review.coreboot.org/#/c/33287/6/payloads/libpayload/sample/Makefile File payloads/libpayload/sample/Makefile: https://review.coreboot.org/#/c/33287/6/payloads/libpayload/sample/Makefile@... PS6, Line 35:
Why are you removing the three archs? POWERPC support has been removed a long time ago so I believe this is correct.
-- To view, visit https://review.coreboot.org/c/coreboot/+/33287 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia32872c43a99357aa966de3582f6fdb2e2652517 Gerrit-Change-Number: 33287 Gerrit-PatchSet: 6 Gerrit-Owner: Asami Doi <d0iasm.pub@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Julius Werner <jwerner@chromium.org> Gerrit-CC: Raul Rangel <rrangel@chromium.org> Gerrit-Comment-Date: Fri, 07 Jun 2019 20:29:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel@chromium.org> Gerrit-MessageType: comment