Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42077 )
Change subject: soc/intel/common/block: Enable PMC IPC driver ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/42077/6/src/soc/intel/common/block/... File src/soc/intel/common/block/pmc/pmclib.c:
https://review.coreboot.org/c/coreboot/+/42077/6/src/soc/intel/common/block/... PS6, Line 47: one more tab to line up with line above
https://review.coreboot.org/c/coreboot/+/42077/6/src/soc/intel/common/block/... PS6, Line 610: const uintptr_t pmcbase = soc_read_pmc_base(); : return (void *)(pmcbase + pmc_reg_offset); I think `return (soc_read_pmc_base() + pmc_reg_offset);` would be enough, the cast to `void *` is not necessary
https://review.coreboot.org/c/coreboot/+/42077/6/src/soc/intel/common/block/... PS6, Line 624: enum cb_err nit: no need to use cb_err for static functions, it's more for exported APIs