3 comments:
File src/soc/intel/common/block/pmc/pmclib.c:
one more tab to line up with line above
const uintptr_t pmcbase = soc_read_pmc_base();
return (void *)(pmcbase + pmc_reg_offset);
I think `return (soc_read_pmc_base() + pmc_reg_offset);` would be enough, the cast to `void *` is not necessary
Patch Set #6, Line 624: enum cb_err
nit: no need to use cb_err for static functions, it's more for exported APIs
To view, visit change 42077. To unsubscribe, or for help writing mail filters, visit settings.