build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 34:
(66 comments)
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@26 PS34, Line 26: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@190 PS34, Line 190: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@214 PS34, Line 214: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@229 PS34, Line 229: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@242 PS34, Line 242: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@250 PS34, Line 250: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@252 PS34, Line 252: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@257 PS34, Line 257: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@269 PS34, Line 269: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@270 PS34, Line 270: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@278 PS34, Line 278: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@294 PS34, Line 294: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@301 PS34, Line 301: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@304 PS34, Line 304: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@307 PS34, Line 307: floppy_verifier "michalos" "8b62d508e30816b64694d99e58cfbeb8be8c4407423e3c3bdef8eefcb32f90ff" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@315 PS34, Line 315: floppy_verifier "fiwix" "6fec5d91a8a8c0d4720e2e2b7c05f94a01226e791a15b8249ee6c337c7744de6" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@319 PS34, Line 319: floppy_verifier "memtest" "d320f0ae56a1c65737e7bc207db22088da982f57236340abc9368860df26ea87" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@324 PS34, Line 324: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@330 PS34, Line 330: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@334 PS34, Line 334: floppy_verifier "floppybird" "249f77da69ba5d3295ed0c9180e4ffc646fb24f545630448fd55d5de2aec1455" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@346 PS34, Line 346: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@352 PS34, Line 352: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@354 PS34, Line 354: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@358 PS34, Line 358: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@373 PS34, Line 373: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@380 PS34, Line 380: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@383 PS34, Line 383: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@384 PS34, Line 384: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@387 PS34, Line 387: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@388 PS34, Line 388: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@391 PS34, Line 391: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@396 PS34, Line 396: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@397 PS34, Line 397: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@412 PS34, Line 412: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@429 PS34, Line 429: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@430 PS34, Line 430: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@431 PS34, Line 431: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@432 PS34, Line 432: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@433 PS34, Line 433: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@434 PS34, Line 434: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@464 PS34, Line 464: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@469 PS34, Line 469: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@540 PS34, Line 540: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@673 PS34, Line 673: [ "$1" = "A88XM-E" ] || [ "$1" = "tint" ] || [ "$1" = "seabios" ] || [ "$1" = "cfgsb" ] ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@676 PS34, Line 676: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@677 PS34, Line 677: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@680 PS34, Line 680: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@740 PS34, Line 740: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@742 PS34, Line 742: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@757 PS34, Line 757: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@759 PS34, Line 759: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@765 PS34, Line 765: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@781 PS34, Line 781: csb_patcher "dgpu" "39873" "5" "760e2ac" "26ba303f88935d1cc3e70374972389663ab3930987ddcea0c05f37bc1ecdcba9" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@786 PS34, Line 786: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@791 PS34, Line 791: csb_patcher "xmp" "40495" "3" "7ddcecd" "27e711f0fed2912e24d7cd0dbe7f865d2ef75e1b068d985b7b8a181e61d3865f" "$1" "support " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@796 PS34, Line 796: csb_patcher "tint" "44582" "1" "e4ab099" "495392b76f40c1f19cc3f99606c8ab042b1c901ddcefc7ee40362ce6fca3adef" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@801 PS34, Line 801: csb_patcher "seabios" "32351" "9" "772fa76" "2e4a553693feb212ff920645f2a082123e3bd86b1edefe52236934177d097171" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@806 PS34, Line 806: csb_patcher "cfgsb" "44638" "1" "fc98bfa" "dae0ff00c5b3aa69d1a205b0e53f3a6c11437e24439bf5b936594506a3ed9d44" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@811 PS34, Line 811: csb_patcher "config.lenovo_g505s" "32352" "30" "f6fb93c" "b3a40483e5b8d13feafc96485ab8db8702d4087f1bee531d8f90c68857b76374" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@816 PS34, Line 816: csb_patcher "config.asus_am1i-a" "33800" "17" "8c6dbab" "e7d1d2b6a329161660542954c856f7b54b8db4520994b3450a47cd8fb00abb26" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@821 PS34, Line 821: csb_patcher "config.asus_a88xm-e" "39900" "4" "7c3332b" "6318af01827e01a235e82aecfdb5346655ff5af4d01f308dadc81c065646549f" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@828 PS34, Line 828: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@831 PS34, Line 831: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@884 PS34, Line 884: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@885 PS34, Line 885: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@907 PS34, Line 907: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters