Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G ......................................................................
Patch Set 63:
(6 comments)
https://review.coreboot.org/c/coreboot/+/35523/62/src/mainboard/acer/aspire_... File src/mainboard/acer/aspire_vn7_572g/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35523/62/src/mainboard/acer/aspire_... PS62, Line 58: 2
I found an ATA error in dmesg once, even with the vendor BIOS. […]
Ack. I wonder if the issue with the Purism Librem is due to lack of HSIO tuning or just bad design. There are HSIO tuning registers but they are publicly undocumented.
https://review.coreboot.org/c/coreboot/+/35523/62/src/mainboard/acer/aspire_... PS62, Line 170: x4
In the schematics, ports 1-4 are connected to PEG. […]
No, they should be left disabled. There's a difference between PCIe root port devices and PCIe lanes. The dGPU is using four PCIe lanes (1..4), but they are all grouped together in a single PCIe root port device.
https://review.coreboot.org/c/coreboot/+/35523/62/src/mainboard/acer/aspire_... PS62, Line 202: register "usb2_ports[4]" = "USB2_PORT_FLEX(OC_SKIP)" # Bluetooth
Device does not have a touchscreen.
Not at all, or not on your model? Leaving it enabled does not cause any harm.
https://review.coreboot.org/c/coreboot/+/35523/62/src/mainboard/acer/aspire_... PS62, Line 204: register "usb2_ports[7]" = "USB2_PORT_FLEX(OC_SKIP)" # SD
Not present.
See above
https://review.coreboot.org/c/coreboot/+/35523/62/src/mainboard/acer/aspire_... PS62, Line 208: # register "usb3_ports[2]" = "USB3_PORT_DEFAULT(OC_SKIP)" # Type-C Port
There's only one Type-C port?
USB Type-C uses two USB 3.0 lanes, though. Yes, I didn't know about that either.
https://review.coreboot.org/c/coreboot/+/35523/62/src/mainboard/acer/aspire_... PS62, Line 240: device pci 01.0 on end # Dedicated Graphics Device
You're right. Volume 2 of the datasheet for 6th gen platforms concurs. […]
Notice that, on line 371, coreboot says it could not find this device. That is, Bus:Dev.Fun 00:01.0 is missing. The GPU should be on a different bus, at 01:00.0
If the dGPU isn't present with coreboot, it is probably power gated because of Optimus.