[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: Enable Audio on TGL

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38147 )

Change subject: soc/intel/tigerlake: Enable Audio on TGL
......................................................................

Patch Set 14:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38147/8/src/soc/intel/tigerlake/rom... 
File src/soc/intel/tigerlake/romstage/fsp_params_tgl.c:

https://review.coreboot.org/c/coreboot/+/38147/8/src/soc/intel/tigerlake/rom... 
PS8, Line 108: m_cfg->PchHdaAudioLinkDmicClkAPinMux[0] = GPIO_VER2_LP_MUXING_DMIC0_CLKA_GPP_S6;
             : 	m_cfg->PchHdaAudioLinkDmicClkBPinMux[0] = GPIO_VER2_LP_MUXING_DMIC0_CLKB_GPP_S2;
             : 	m_cfg->PchHdaAudioLinkDmicDataPinMux[0] = GPIO_VER2_LP_MUXING_DMIC0_DATA_GPP_S7;
             : 	m_cfg->PchHdaAudioLinkDmicClkAPinMux[1] = GPIO_VER2_LP_MUXING_DMIC1_CLKA_GPP_S4;
             : 	m_cfg->PchHdaAudioLinkDmicClkBPinMux[1] = GPIO_VER2_LP_MUXING_DMIC1_CLKB_GPP_S3;
             : 	m_cfg->PchHdaAudioLinkDmicDataPinMux[1] = GPIO_VER2_LP_MUXING_DMIC1_DATA_GPP_S5;
> I have updated the bug with my comments, can we get this patch merged in the meantime ?

Did you try the latest diff I provided? I believe with that diff you shouldn't need this UPD setting in coreboot.