[coreboot-gerrit] [M] Change in coreboot[main]: arch/arm64: Implement initial set of SMBIOS tables

[Julius Werner (Code Review)]

Attention is currently required from: Arthur Heymans, Benjamin Doron, David Milosevic, Lean Sheng Tan, Martin L Roth, Maximilian Brune.

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78285?usp=email )

Change subject: arch/arm64: Implement initial set of SMBIOS tables
......................................................................

Patch Set 15: Code-Review+2

(2 comments)

Patchset:

PS15: 
LGTM after the points Arthur mentioned.

File src/arch/arm64/smbios.c:

https://review.coreboot.org/c/coreboot/+/78285/comment/d5437765_d4578fe8 :
PS15, Line 74: t->core_count = MAX_CPUS_ENABLED(t->core_count2);
             : 	t->thread_count = MAX_CPUS_ENABLED(t->thread_count2);
> SMP is now a thing in ARM right? Maybe the SOC should provide this info? Maybe add a TODO comment?

I think(?) that's what's happening here now. `smbios_cpu_get_core_counts()` will need to be implemented by each SoC or mainboard to provide those counts.