Attention is currently required from: Arthur Heymans, Benjamin Doron, David Milosevic, Lean Sheng Tan, Martin L Roth, Maximilian Brune.

Patch set 15:Code-Review +2

View Change

2 comments:

• Patchset:

  • Patch Set #15:

    LGTM after the points Arthur mentioned.

• File src/arch/arm64/smbios.c:

  • Patch Set #15, Line 74:

    t->core_count = MAX_CPUS_ENABLED(t->core_count2);
    	t->thread_count = MAX_CPUS_ENABLED(t->thread_count2);
    

    SMP is now a thing in ARM right? Maybe the SOC should provide this info? Maybe add a TODO comment?

    I think(?) that's what's happening here now. `smbios_cpu_get_core_counts()` will need to be implemented by each SoC or mainboard to provide those counts.

To view, visit change 78285. To unsubscribe, or for help writing mail filters, visit settings.