Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38266 )
Change subject: aopen/dxplplusu,intel/e7505: Move mainboard_romstage_entry()
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38266/1/src/northbridge/intel/e7505...
File src/northbridge/intel/e7505/romstage.c:
https://review.coreboot.org/c/coreboot/+/38266/1/src/northbridge/intel/e7505...
PS1, Line 29:
: .channel0 = { 0x50, 0x52, 0, 0 },
: .channel1 = { 0x51, 0x53, 0, 0 },
Aren't these mainboard-specific?
Yes, but we have just one board in the tree. I will make this look more like i945 one day.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38266
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15aaefdf0c81f58adfeb6f4dde2f05b3c06fd145
Gerrit-Change-Number: 38266
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 09 Jan 2020 14:50:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment