Change in coreboot[master]: aopen/dxplplusu,intel/e7505: Move mainboard_romstage_entry()
Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38266 )
Change subject: aopen/dxplplusu,intel/e7505: Move mainboard_romstage_entry() ......................................................................
aopen/dxplplusu,intel/e7505: Move mainboard_romstage_entry()
Change-Id: I15aaefdf0c81f58adfeb6f4dde2f05b3c06fd145 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/northbridge/intel/e7505/Makefile.inc R src/northbridge/intel/e7505/romstage.c 2 files changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/38266/1
diff --git a/src/northbridge/intel/e7505/Makefile.inc b/src/northbridge/intel/e7505/Makefile.inc index 9b68e13..29ac437 100644 --- a/src/northbridge/intel/e7505/Makefile.inc +++ b/src/northbridge/intel/e7505/Makefile.inc @@ -3,6 +3,7 @@ ramstage-y += northbridge.c ramstage-y += memmap.c
+romstage-y += romstage.c romstage-y += raminit.c romstage-y += memmap.c
diff --git a/src/mainboard/aopen/dxplplusu/romstage.c b/src/northbridge/intel/e7505/romstage.c similarity index 100% rename from src/mainboard/aopen/dxplplusu/romstage.c rename to src/northbridge/intel/e7505/romstage.c
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38266 )
Change subject: aopen/dxplplusu,intel/e7505: Move mainboard_romstage_entry() ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/38266/1/src/northbridge/intel/e7505... File src/northbridge/intel/e7505/romstage.c:
https://review.coreboot.org/c/coreboot/+/38266/1/src/northbridge/intel/e7505... PS1, Line 29: : .channel0 = { 0x50, 0x52, 0, 0 }, : .channel1 = { 0x51, 0x53, 0, 0 }, Aren't these mainboard-specific?
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38266 )
Change subject: aopen/dxplplusu,intel/e7505: Move mainboard_romstage_entry() ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38266/1/src/northbridge/intel/e7505... File src/northbridge/intel/e7505/romstage.c:
https://review.coreboot.org/c/coreboot/+/38266/1/src/northbridge/intel/e7505... PS1, Line 29: : .channel0 = { 0x50, 0x52, 0, 0 }, : .channel1 = { 0x51, 0x53, 0, 0 },
Aren't these mainboard-specific?
Yes, but we have just one board in the tree. I will make this look more like i945 one day.
Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38266 )
Change subject: aopen/dxplplusu,intel/e7505: Move mainboard_romstage_entry() ......................................................................
aopen/dxplplusu,intel/e7505: Move mainboard_romstage_entry()
Change-Id: I15aaefdf0c81f58adfeb6f4dde2f05b3c06fd145 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38266 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/e7505/Makefile.inc R src/northbridge/intel/e7505/romstage.c 2 files changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/northbridge/intel/e7505/Makefile.inc b/src/northbridge/intel/e7505/Makefile.inc index 9b68e13..29ac437 100644 --- a/src/northbridge/intel/e7505/Makefile.inc +++ b/src/northbridge/intel/e7505/Makefile.inc @@ -3,6 +3,7 @@ ramstage-y += northbridge.c ramstage-y += memmap.c
+romstage-y += romstage.c romstage-y += raminit.c romstage-y += memmap.c
diff --git a/src/mainboard/aopen/dxplplusu/romstage.c b/src/northbridge/intel/e7505/romstage.c similarity index 100% rename from src/mainboard/aopen/dxplplusu/romstage.c rename to src/northbridge/intel/e7505/romstage.c
-
Angel Pons (Code Review) -
Kyösti Mälkki (Code Review)