Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48156 )
Change subject: arch/x86: Don't use .bss from car.ld if not running XIP ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
I'll hope to defer to someone using non-XIP and CAR for +2, however it looks OK to me now.
https://review.coreboot.org/c/coreboot/+/48156/1/src/arch/x86/assembly_entry... File src/arch/x86/assembly_entry.S:
https://review.coreboot.org/c/coreboot/+/48156/1/src/arch/x86/assembly_entry... PS1, Line 39: ENV_STAGE_XIP
Using this rule will eliminate clearing .bss on Picasso where we have CONFIG(RESET_VECTOR_IN_RAM). […]
Oh, you're right. It's cleared in cbfs_prog_stage_load().
https://review.coreboot.org/c/coreboot/+/48156/1/src/include/rules.h File src/include/rules.h:
https://review.coreboot.org/c/coreboot/+/48156/1/src/include/rules.h@276 PS1, Line 276: stages uses nit - maybe "stage uses".