I'll hope to defer to someone using non-XIP and CAR for +2, however it looks OK to me now.

Patch set 1:Code-Review +1

View Change

2 comments:

• File src/arch/x86/assembly_entry.S:

  • Patch Set #1, Line 39: ENV_STAGE_XIP

    > Using this rule will eliminate clearing .bss on Picasso where we have CONFIG(RESET_VECTOR_IN_RAM). […]

    Oh, you're right. It's cleared in cbfs_prog_stage_load().

• File src/include/rules.h:

  • Patch Set #1, Line 276: stages uses

    nit - maybe "stage uses".

To view, visit change 48156. To unsubscribe, or for help writing mail filters, visit settings.