[coreboot-gerrit] Change in ...coreboot[master]: util/superiotool: Add AST2400

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32984 )

Change subject: util/superiotool: Add AST2400
......................................................................

Patch Set 2:
> Patch Set 2:
> > Patch Set 2:
> > > Patch Set 2:
> > >
> > > not that it makes a big difference here, but is the SIO part of the ast2400 behind a PCI(e) device or is it connected to the LPC bus?
> >
> > It's connected to PCIe, LPC and USB.
>
> Logically, I believe SIO must be on LPC; PCI bridges only forward IO transactions that fall within the (configured) IO window in PCI configuration register space.

IIRC at least in some platforms it depends on if the LPC or PCI bus is selected as target for the subtraction IO decode; haven't looked at the details though