Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45056 )
Change subject: soc/amd/picasso: Add MADT entry for GNB IOAPIC ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45056/6/src/soc/amd/picasso/acpi.c File src/soc/amd/picasso/acpi.c:
https://review.coreboot.org/c/coreboot/+/45056/6/src/soc/amd/picasso/acpi.c@... PS6, Line 50: FSP populates this generates this HOB if it initializes second IOAPIC
With the current patches in flight, it'll be enabled all the time. […]
I ask because I am wondering if we should pass in the IOAPIC address for the NB from coreboot to FSP as a UPD instead of adding another HOB for it. That way you don't really need to check for the HOB in all places where it has to be used and instead rely on using the macro/Kconfig.
Also, probably we want to also declare it as reserved resource here: https://review.coreboot.org/cgit/coreboot.git/tree/src/soc/amd/common/block/...
https://review.coreboot.org/c/coreboot/+/45056/6/src/soc/amd/picasso/acpi.c@... PS6, Line 54:
I suspect it was meant to be indented, e.g. […]
I see. Sounds good.