Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34349 )
Change subject: soc/intel/{cnl,icl}: Add support to configure interrupt overrides ......................................................................
Patch Set 15: Code-Review-2
(3 comments)
https://review.coreboot.org/c/coreboot/+/34349/15/src/soc/intel/icelake/fsp_... File src/soc/intel/icelake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/34349/15/src/soc/intel/icelake/fsp_... PS15, Line 245: DevIntConfigPtr What format does it take, What PCI functions should be allow to pass, what are the constraints? Without properly documentating this it is impossible to review this CL.
https://review.coreboot.org/c/coreboot/+/34349/15/src/soc/intel/icelake/fsp_... PS15, Line 246: soc_get_irq_config Check for NULL?
https://review.coreboot.org/c/coreboot/+/34349/15/src/soc/intel/icelake/irq.... File src/soc/intel/icelake/irq.c:
https://review.coreboot.org/c/coreboot/+/34349/15/src/soc/intel/icelake/irq.... PS15, Line 95: irq_config This is bad. The scope of the variables is only inside this function!