Patch set 15:Code-Review -2
3 comments:
File src/soc/intel/icelake/fsp_params.c:
Patch Set #15, Line 245: DevIntConfigPtr
What format does it take, What PCI functions should be allow to pass, what are the constraints? Without properly documentating this it is impossible to review this CL.
Patch Set #15, Line 246: soc_get_irq_config
Check for NULL?
File src/soc/intel/icelake/irq.c:
Patch Set #15, Line 95: irq_config
This is bad. The scope of the variables is only inside this function!
To view, visit change 34349. To unsubscribe, or for help writing mail filters, visit settings.