[coreboot-gerrit] [S] Change in coreboot[main]: sb/amd/pi/hudson/Kconfig: replace HUDSON_LEGACY_FREE option

[Arthur Heymans (Code Review)]

Attention is currently required from: Felix Held, Matt DeVillier, Michał Żygowski, Piotr Król.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79893?usp=email )

Change subject: sb/amd/pi/hudson/Kconfig: replace HUDSON_LEGACY_FREE option
......................................................................

Patch Set 1: Code-Review+2

(1 comment)

File src/southbridge/amd/pi/hudson/fadt.c:

https://review.coreboot.org/c/coreboot/+/79893/comment/55100c4c_1930477f :
PS1, Line 38: fadt->iapc_boot_arch = ACPI_FADT_LEGACY_FREE;	/* See table 5-10 */
            : 	if (CONFIG(HUDSON_FADT_LEGACY_DEVICES))
            : 		fadt->iapc_boot_arch |= ACPI_FADT_LEGACY_DEVICES;
            : 	if (CONFIG(HUDSON_FADT_8042))
            : 		fadt->iapc_boot_arch |= ACPI_FADT_8042;
I'm curious whether the compiler creates code with one write. If you really want it in one write you could use "ACPI_FADT_LEGACY_FREE | CONFIG(HUDSON_FADT_LEGACY_DEVICES) ? ACPI_FADT_LEGACY_DEVICES : 0 ...