Attention is currently required from: Felix Held, Matt DeVillier, Michał Żygowski, Piotr Król.

Patch set 1:Code-Review +2

1 comment:

File src/southbridge/amd/pi/hudson/fadt.c:
- Patch Set #1, Line 38:
```
fadt->iapc_boot_arch = ACPI_FADT_LEGACY_FREE;	/* See table 5-10 */
	if (CONFIG(HUDSON_FADT_LEGACY_DEVICES))
		fadt->iapc_boot_arch |= ACPI_FADT_LEGACY_DEVICES;
	if (CONFIG(HUDSON_FADT_8042))
		fadt->iapc_boot_arch |= ACPI_FADT_8042;
```
  I'm curious whether the compiler creates code with one write. If you really want it in one write you could use "ACPI_FADT_LEGACY_FREE | CONFIG(HUDSON_FADT_LEGACY_DEVICES) ? ACPI_FADT_LEGACY_DEVICES : 0 ...

To view, visit change 79893. To unsubscribe, or for help writing mail filters, visit settings.