build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 50:
(66 comments)
File csb_patcher.sh:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/1509538b_c9547a11 PS50, Line 26: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/34cadf91_3eb691f2 PS50, Line 190: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/9d7603e7_0af5c9fe PS50, Line 214: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/5c2a7f0b_b35f3ae4 PS50, Line 229: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/a500a03e_e9dd57d7 PS50, Line 242: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/4c0a9e78_d80fccab PS50, Line 250: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/95541802_eee4dfc0 PS50, Line 252: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/e84dc084_622cc45f PS50, Line 257: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/b8cef755_fff81529 PS50, Line 269: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/3333514f_e67873ba PS50, Line 270: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/e5058a63_3cfbed7e PS50, Line 278: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/2d24e12e_9c35d471 PS50, Line 294: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/f50382b5_cfcb55ae PS50, Line 301: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/9a3b0bc0_4028f997 PS50, Line 304: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/2529b2a8_8ff61d5e PS50, Line 307: floppy_verifier "michalos" "8b62d508e30816b64694d99e58cfbeb8be8c4407423e3c3bdef8eefcb32f90ff" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/c2068d8d_d5a1db35 PS50, Line 315: floppy_verifier "fiwix" "9ec69b7b1a7554ff1aad784304c3926cad69e95abcac1f8a846a7f6251e25fd9" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/0f687ef2_073ec8f6 PS50, Line 319: floppy_verifier "memtest" "d320f0ae56a1c65737e7bc207db22088da982f57236340abc9368860df26ea87" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/72f12896_c298c99f PS50, Line 324: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/56100ac2_48c941e5 PS50, Line 330: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/fe257ea1_f1262288 PS50, Line 334: floppy_verifier "floppybird" "249f77da69ba5d3295ed0c9180e4ffc646fb24f545630448fd55d5de2aec1455" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/33bb6cd2_ce937d2a PS50, Line 346: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/1aa7f228_edafd1da PS50, Line 352: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/ca74da0f_558b302d PS50, Line 354: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/7f3a5277_0f387650 PS50, Line 358: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/a9270590_26bba597 PS50, Line 373: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/3d10cb2a_ec9a62ce PS50, Line 380: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/b3560873_14688c23 PS50, Line 383: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/eb2cafad_5c639408 PS50, Line 384: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/688c454e_e2fe8a81 PS50, Line 387: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/ac716a08_70b73856 PS50, Line 388: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/3fc4e5d3_0d1a4d1d PS50, Line 391: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/78469ad1_5f9f1caf PS50, Line 396: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/b4e10228_23e2021f PS50, Line 397: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/4aca1c6b_42df9060 PS50, Line 412: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/b4661f41_0832a6f5 PS50, Line 429: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/8350cf84_2657aa7c PS50, Line 430: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/d78dac02_78b682a0 PS50, Line 431: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/2e9d72ae_78c0cb3f PS50, Line 432: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/e6666b6b_ba99fd87 PS50, Line 433: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/0a8c4c5d_3a111fb4 PS50, Line 434: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/5146f063_df6a2db0 PS50, Line 464: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/ea4753bb_bb72131d PS50, Line 469: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/e8f53a6a_ad3fe2c9 PS50, Line 540: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/3b5b4b27_2a70a9aa PS50, Line 673: [ "$1" = "A88XM-E" ] || [ "$1" = "tint" ] || [ "$1" = "seabios" ] || [ "$1" = "cfgsb" ] ; then line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/dce1ff86_1f7d2216 PS50, Line 676: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/a35119af_2f79ed49 PS50, Line 677: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/a2c794b9_619fd51a PS50, Line 680: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/04029daf_8c1c4370 PS50, Line 740: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/3e46523b_c0760b69 PS50, Line 742: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/9c95732a_800cd8d8 PS50, Line 757: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/02ed9936_c6c6925e PS50, Line 759: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/91b50fd6_fc1e02ba PS50, Line 765: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/4ea4219e_93dd6275 PS50, Line 781: csb_patcher "dgpu" "39873" "9" "59a4e65" "5fc8584bb61a5ec1a1e19e3158150f8e63868e07196cbdb9b57facc21f40f610" "$1" "G505S " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/84e5b766_ee5e847d PS50, Line 786: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/92225b58_518e8266 PS50, Line 791: csb_patcher "irq" "48427" "7" "1fc5952" "eeaed646e848156ee4f59a85bf15d0bc5651352330afec260c5ad74305cc8672" "$1" "AMD good " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/4a1478fa_6759a37c PS50, Line 796: csb_patcher "tint" "50991" "1" "ae15153" "76ec0b52a926cd29774406c3ecf9bd55e27f2d35fff970dc7bbcd12b3f1e31b7" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/d5ab1979_a9433ac8 PS50, Line 801: csb_patcher "seabios" "32351" "15" "c4fc787" "b15163a492215c3155e3029415bf07a4514d6c02dd393ad09148d2d4adc17657" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/9c002a4d_c380de53 PS50, Line 806: csb_patcher "cfgsb" "44638" "1" "fc98bfa" "dae0ff00c5b3aa69d1a205b0e53f3a6c11437e24439bf5b936594506a3ed9d44" "$1" "for-configs " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/9ed29c67_08cdc573 PS50, Line 811: csb_patcher "config.lenovo_g505s" "32352" "37" "a90256b" "ae7a0f2097ec71b215c421df695fc5adc021636240810b0b0a139ae41f975272" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/7672e957_e7aeb5e6 PS50, Line 816: csb_patcher "config.asus_am1i-a" "33800" "24" "7aa38bc" "f0522955c9394e58e9e10f1d7dabcc5f8c643e7af548cefe5bc4856cf754a9e9" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/a2cc0b7a_858fd77f PS50, Line 821: csb_patcher "config.asus_a88xm-e" "39900" "11" "00eb676" "ab89fcd3c01e657f36c5845af0921d080209c06ce3077635bf53a56408ddb18d" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/8ba5267b_c3367651 PS50, Line 828: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/05ff129c_dcaa96d4 PS50, Line 831: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/0c5eb16a_0c472766 PS50, Line 884: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/f50f2d7c_9a70e423 PS50, Line 885: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/754f3580_fa005fdc PS50, Line 907: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters