Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/44786 )
Change subject: gma registers: Allow to specify an offset for display registers ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/libgfxinit/+/44786/3/common/hw-gfx-gma-config.... File common/hw-gfx-gma-config.ads.template:
https://review.coreboot.org/c/libgfxinit/+/44786/3/common/hw-gfx-gma-config.... PS3, Line 357: Base_Offset Nit `base` and `offset` sound redundant. Maybe just `Display_Base` like the already present `Fence_Base`?
https://review.coreboot.org/c/libgfxinit/+/44786/3/common/hw-gfx-gma-registe... File common/hw-gfx-gma-registers.adb:
https://review.coreboot.org/c/libgfxinit/+/44786/3/common/hw-gfx-gma-registe... PS3, Line 214: return Reg'Enum_Rep + Config.Display_Base_Offset / Register_Width; I don't understand. This Index() function is used for all registers, not just the display registers. Shouldn't the offset be added to individual registers?