2 comments:
File common/hw-gfx-gma-config.ads.template:
Patch Set #3, Line 357: Base_Offset
Nit `base` and `offset` sound redundant. Maybe just `Display_Base` like
the already present `Fence_Base`?
File common/hw-gfx-gma-registers.adb:
Patch Set #3, Line 214: return Reg'Enum_Rep + Config.Display_Base_Offset / Register_Width;
I don't understand. This Index() function is used for all registers, not just the
display registers. Shouldn't the offset be added to individual registers?
To view, visit change 44786. To unsubscribe, or for help writing mail filters, visit settings.