build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44424 )
Change subject: mb/google/zork: Add helper function to read DB ID bits in FW_CONFIG ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44424/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/helpers.c:
https://review.coreboot.org/c/coreboot/+/44424/1/src/mainboard/google/zork/v... PS1, Line 150: return extract_field(FW_CONFIG_MASK_DB_INDEX, FW_CONFIG_DB_INDEX_SHIFT); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/44424/1/src/mainboard/google/zork/v... PS1, Line 150: return extract_field(FW_CONFIG_MASK_DB_INDEX, FW_CONFIG_DB_INDEX_SHIFT); please, no spaces at the start of a line