Change in coreboot[master]: mb/google/zork: Add helper function to read DB ID bits in FW_CONFIG
Bhanu Prakash Maiya has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44424 )
Change subject: mb/google/zork: Add helper function to read DB ID bits in FW_CONFIG ......................................................................
mb/google/zork: Add helper function to read DB ID bits in FW_CONFIG
Add helper function variant_get_daughterboard_id() to read daughterboard id bits (0-3) in firmware configuration table in CBI.
BRANCH=none BUG=b:162344105,b:152817444 TEST=Check if daughterboard id bits (0-3) can be read from FW_CONFIG.
Signed-off-by: Bhanu Prakash Maiya bhanumaiya@google.com Change-Id: Ia3c882439bfbe6da28be2df0ec0c976d5c142677 --- M src/mainboard/google/zork/variants/baseboard/helpers.c M src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h 2 files changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/44424/1
diff --git a/src/mainboard/google/zork/variants/baseboard/helpers.c b/src/mainboard/google/zork/variants/baseboard/helpers.c index 3f2b068..926a34b 100644 --- a/src/mainboard/google/zork/variants/baseboard/helpers.c +++ b/src/mainboard/google/zork/variants/baseboard/helpers.c @@ -144,3 +144,8 @@
return true; } + +int variant_get_daughterboard_id(void) +{ + return extract_field(FW_CONFIG_MASK_DB_INDEX, FW_CONFIG_DB_INDEX_SHIFT); +} diff --git a/src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h index 98ba565..bedcb0d 100644 --- a/src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h +++ b/src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h @@ -72,5 +72,7 @@ bool variant_uses_codec_gpi(void); /* Return true if variant has active low power enable fow WiFi. */ bool variant_has_active_low_wifi_power(void); +/* Return value of daughterboard ID */ +int variant_get_daughterboard_id(void);
#endif /* __BASEBOARD_VARIANTS_H__ */
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44424 )
Change subject: mb/google/zork: Add helper function to read DB ID bits in FW_CONFIG ......................................................................
Patch Set 1: Code-Review+2
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44424 )
Change subject: mb/google/zork: Add helper function to read DB ID bits in FW_CONFIG ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44424/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/helpers.c:
https://review.coreboot.org/c/coreboot/+/44424/1/src/mainboard/google/zork/v... PS1, Line 150: return extract_field(FW_CONFIG_MASK_DB_INDEX, FW_CONFIG_DB_INDEX_SHIFT); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/44424/1/src/mainboard/google/zork/v... PS1, Line 150: return extract_field(FW_CONFIG_MASK_DB_INDEX, FW_CONFIG_DB_INDEX_SHIFT); please, no spaces at the start of a line
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44424 )
Change subject: mb/google/zork: Add helper function to read DB ID bits in FW_CONFIG ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44424/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/helpers.c:
https://review.coreboot.org/c/coreboot/+/44424/1/src/mainboard/google/zork/v... PS1, Line 150: return extract_field(FW_CONFIG_MASK_DB_INDEX, FW_CONFIG_DB_INDEX_SHIFT);
code indent should use tabs where possible
Need to use tab instead of spaces before "return ..."
Hello build bot (Jenkins), Furquan Shaikh, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44424
to look at the new patch set (#2).
Change subject: mb/google/zork: Add helper function to read DB ID bits in FW_CONFIG ......................................................................
mb/google/zork: Add helper function to read DB ID bits in FW_CONFIG
Add helper function variant_get_daughterboard_id() to read daughterboard id bits (0-3) in firmware configuration table in CBI.
BRANCH=none BUG=b:162344105,b:152817444 TEST=Check if daughterboard id bits (0-3) can be read from FW_CONFIG.
Signed-off-by: Bhanu Prakash Maiya bhanumaiya@google.com Change-Id: Ia3c882439bfbe6da28be2df0ec0c976d5c142677 --- M src/mainboard/google/zork/variants/baseboard/helpers.c M src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h 2 files changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/44424/2
Bhanu Prakash Maiya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44424 )
Change subject: mb/google/zork: Add helper function to read DB ID bits in FW_CONFIG ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44424/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/helpers.c:
https://review.coreboot.org/c/coreboot/+/44424/1/src/mainboard/google/zork/v... PS1, Line 150: return extract_field(FW_CONFIG_MASK_DB_INDEX, FW_CONFIG_DB_INDEX_SHIFT);
Need to use tab instead of spaces before "return ... […]
Ack
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44424 )
Change subject: mb/google/zork: Add helper function to read DB ID bits in FW_CONFIG ......................................................................
Patch Set 2: Code-Review+2
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44424 )
Change subject: mb/google/zork: Add helper function to read DB ID bits in FW_CONFIG ......................................................................
Patch Set 2: Code-Review+2
Aaron Durbin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44424 )
Change subject: mb/google/zork: Add helper function to read DB ID bits in FW_CONFIG ......................................................................
mb/google/zork: Add helper function to read DB ID bits in FW_CONFIG
Add helper function variant_get_daughterboard_id() to read daughterboard id bits (0-3) in firmware configuration table in CBI.
BRANCH=none BUG=b:162344105,b:152817444 TEST=Check if daughterboard id bits (0-3) can be read from FW_CONFIG.
Signed-off-by: Bhanu Prakash Maiya bhanumaiya@google.com Change-Id: Ia3c882439bfbe6da28be2df0ec0c976d5c142677 Reviewed-on: https://review.coreboot.org/c/coreboot/+/44424 Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Aaron Durbin adurbin@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/zork/variants/baseboard/helpers.c M src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h 2 files changed, 7 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/zork/variants/baseboard/helpers.c b/src/mainboard/google/zork/variants/baseboard/helpers.c index 3f2b068..d95ab82 100644 --- a/src/mainboard/google/zork/variants/baseboard/helpers.c +++ b/src/mainboard/google/zork/variants/baseboard/helpers.c @@ -144,3 +144,8 @@
return true; } + +int variant_get_daughterboard_id(void) +{ + return extract_field(FW_CONFIG_MASK_DB_INDEX, FW_CONFIG_DB_INDEX_SHIFT); +} diff --git a/src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h index 98ba565..bedcb0d 100644 --- a/src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h +++ b/src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h @@ -72,5 +72,7 @@ bool variant_uses_codec_gpi(void); /* Return true if variant has active low power enable fow WiFi. */ bool variant_has_active_low_wifi_power(void); +/* Return value of daughterboard ID */ +int variant_get_daughterboard_id(void);
#endif /* __BASEBOARD_VARIANTS_H__ */
-
Aaron Durbin (Code Review) -
Bhanu Prakash Maiya (Code Review)
-
build bot (Jenkins) (Code Review)
-
Furquan Shaikh (Code Review)