Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33031 )
Change subject: src/soc/intel/common/smbios: Add addtional infos to dimm_info
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/33031/2/src/include/memory_info.h
File src/include/memory_info.h:
https://review.coreboot.org/#/c/33031/2/src/include/memory_info.h@90
PS2, Line 90: * Voltage Level
missing unit (I guess mV). u16 should be sufficient
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33031
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic6f0d4b223f1490ec7aa71a6105603635b514021
Gerrit-Change-Number: 33031
Gerrit-PatchSet: 2
Gerrit-Owner: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Tue, 28 May 2019 09:59:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment