Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36457 )
Change subject: soc/intel/{cnl,icl}: Move globalnvs.asl/nvs.h into common/block/
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36457/6/src/soc/intel/cannonlake/in...
File src/soc/intel/cannonlake/include/soc/nvs.h:
PS6:
If NVS is moved completely to common code, why retain this placeholder file? Isn't it better to just […]
I see a comment on earlier patchset related to this. I think we should get rid of this file in the soc/ paths and mainboards for those SoC which are already moved to use common code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36457
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia9fb12a75557bd7dc38f6d22ba2b32065d18b3ee
Gerrit-Change-Number: 36457
Gerrit-PatchSet: 6
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 01 Nov 2019 18:29:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment