Attention is currently required from: Maxim Polyakov, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39374 )
Change subject: soc/{apl,glk}: Allow to select the primary graphics device ......................................................................
Patch Set 29:
(2 comments)
File src/soc/intel/apollolake/chip.h:
https://review.coreboot.org/c/coreboot/+/39374/comment/1fd46468_45a64403 PS29, Line 33: }; `chip.h` is an API between our platform/driver and mainboard code. This is FSP specific, though. It should be moved to the code. I'd place it on the top inside soc_gpu_init_params().
If I interpreted your test results correctly, this change looks good otherwise.
File src/soc/intel/apollolake/chip.h:
https://review.coreboot.org/c/coreboot/+/39374/comment/fabc38f9_787ba9f6 PS17, Line 45: PRIMARY_AUTO = 0, : PRIMARY_IGD = 2, : PRIMARY_PCI = 3,
This works the same as for Skylake. […]
Angel, did you check some code drop or the current binary? If it really makes a difference if we set 2 or 3, this change seems valid. However, I have to say: as it is common when we add features that nobody needs yet, it can waste a lot of time. We don't know what will happen first: a) FSP vanishes, b) somebody will make use of this feature.