Attention is currently required from: Maxim Polyakov, Angel Pons.
2 comments:
File src/soc/intel/apollolake/chip.h:
`chip.h` is an API between our platform/driver and mainboard code. This
is FSP specific, though. It should be moved to the code. I'd place it on
the top inside soc_gpu_init_params().
If I interpreted your test results correctly, this change looks good
otherwise.
File src/soc/intel/apollolake/chip.h:
PRIMARY_AUTO = 0,
PRIMARY_IGD = 2,
PRIMARY_PCI = 3,
This works the same as for Skylake. […]
Angel, did you check some code drop or the current binary? If it really
makes a difference if we set 2 or 3, this change seems valid. However,
I have to say: as it is common when we add features that nobody needs yet,
it can waste a lot of time. We don't know what will happen first: a)
FSP vanishes, b) somebody will make use of this feature.
To view, visit change 39374. To unsubscribe, or for help writing mail filters, visit settings.