Kevin Cody has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38207 )
Change subject: soc/intel/skylake: Move "select SOC_INTEL_COMMON_BLOCK_GPIO_LEGACY_MACROS" to individual mainboard Kconfig's ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38207/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38207/3//COMMIT_MSG@7 PS3, Line 7: Move
Please use a shorter topic
Done
https://review.coreboot.org/c/coreboot/+/38207/3//COMMIT_MSG@9 PS3, Line 9: legacying
I'm not aware of mainboard specific gpio asl code. […]
There are semantic changes to some of the macros defined in src/soc/intel/common/block/include/intelblocks/gpio_defs.h, notably PAD_CFG_GPI_APIC changes its number of arguments, and there are a handful of others macros that have changed.
To remove that Kconfig symbol, the gpio.h for each board/variant needs to be picked through to replace any of the macros defined within #if CONFIG(SOC_INTEL_COMMON_BLOCK_GPIO_LEGACY_MACROS) in the above mentioned files, with the newer macros.
Detailed instructions: https://docs.google.com/document/d/1X4Q5umA2tLxstdG6PkSMoEQCrTBXMZ_6KUqb-GkO...